Skip to content

[docs] Add CODEOWNERS suggestion to CONTRIBUTING.md#22935

Closed
steveburnett wants to merge 1 commit intoprestodb:masterfrom
steveburnett:steveburnett-contributing-committers
Closed

[docs] Add CODEOWNERS suggestion to CONTRIBUTING.md#22935
steveburnett wants to merge 1 commit intoprestodb:masterfrom
steveburnett:steveburnett-contributing-committers

Conversation

@steveburnett
Copy link
Contributor

@steveburnett steveburnett commented Jun 6, 2024

Description

Motivation and Context

The first addresses a suggestion that I made in #22641. The second fixes a text error.

Impact

Documentation.

Test Plan

Pushed branch to my fork of the repo and View File to see the file as it will be displayed in GitHub. Also, CI.

  • Screenshot of new Committers topic, showing the added text in the two sentences beginning with "See CODEOWNERS for modules, connectors, [...]".
Screenshot 2024-06-06 at 10 44 52 AM
  • Screenshot of current CONTRIBUTING.md, showing the empty Requirements heading that this PR deletes.
Screenshot 2024-06-06 at 11 01 34 AM

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@steveburnett steveburnett self-assigned this Jun 6, 2024
@steveburnett steveburnett requested a review from a team as a code owner June 6, 2024 15:12
@steveburnett steveburnett requested a review from presto-oss June 6, 2024 15:12
@github-actions github-actions bot removed the docs label Jun 6, 2024
@tdcmeehan
Copy link
Contributor

I opened #22942 which includes this, will close in favor of that PR @steveburnett!

@tdcmeehan tdcmeehan closed this Jun 6, 2024
@steveburnett steveburnett deleted the steveburnett-contributing-committers branch June 6, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants