Remove deprecated feature group-by-uses-equal#22888
Merged
rschlussel merged 1 commit intoprestodb:masterfrom Jun 3, 2024
Merged
Remove deprecated feature group-by-uses-equal#22888rschlussel merged 1 commit intoprestodb:masterfrom
rschlussel merged 1 commit intoprestodb:masterfrom
Conversation
6 tasks
jaystarshot
previously approved these changes
May 31, 2024
22e3fbf to
a060870
Compare
elharo
previously approved these changes
May 31, 2024
elharo
reviewed
May 31, 2024
Contributor
elharo
left a comment
There was a problem hiding this comment.
[INFO] There is 1 error reported by Checkstyle 8.16 with src/checkstyle/presto-checks.xml ruleset.
Error: src/test/java/com/facebook/presto/hive/TestHivePageSink.java:[36,8] (imports) UnusedImports: Unused import - com.facebook.presto.sql.analyzer.FeaturesConfig.
Remove deprecated legacy behavior for group by to use equal to rather than distinct. Remove the corresponding config `deprecated.group-by-uses-equal`
a060870 to
2e8f70d
Compare
Contributor
|
Can you give a brief context on what this feature is and why we are removing it? |
Contributor
Author
The original implementation of group by in Presto was incorrectly using equal to rather than is distinct from. When that was fixed, this config was added to use the legacy behavior baad26e. It's been deprecated a long time, and I think we can safely remove it now. |
feilong-liu
approved these changes
Jun 3, 2024
NikhilCollooru
approved these changes
Jun 3, 2024
36 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove deprecated legacy behavior for group by to use equal to rather than distinct. Remove the corresponding config
deprecated.group-by-uses-equalMotivation and Context
Clean up of deprecated/not maintained feature.
Impact
see above
Test Plan
CI
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.