Update docs theme to sphinx-immaterial#22887
Conversation
|
Nice! Thanks for including the screenshot of the new style. I've done a local build of your branch and it looks the same as your screenshot, which is not surprising at all but nice nonetheless. One question: |
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull updated branch, new local docs build.
- The "View page source / Edit this page / Create docs issue / Create project issue" links in the existing doc's right sidebar are back as requested.
- The light/dark mode toggle is present and it works - thanks for adding it in!
I have no other concerns. This fixes the original problem of the missing Presto logo, updates us to a currently-maintained Sphinx theme, and adds a light/dark mode feature for our readers. Thanks!
|
@tdcmeehan would you like to look before I merge this? |
Also, added auto-scrolling TOC and system media queries for automatically picking dark/light mode color schemes.
|
Just noticed this today, not sure when it happened. Some of the right border tables of content for individual pages have the headings preceded with a purple "M" character. This affects most of the pages in /functions/ and in /rest/, but I didn't find this problem elsewhere in the Presto doc set. I'm not seeing any errors or warnings in a local docs build that would explain this. Example screenshots from a local docs build of https://prestodb.io/docs/current/functions/conversion.html, and https://prestodb.io/docs/current/rest/node.html. |
|
@steveburnett That's part of the theme -- when using the |
|
@ZacBlanco thanks - I thought they might be a feature of the theme instead of a bug, but I wanted to ask. If you can find an easy way to disable this feature, I'd appreciate it. |




Updates our old docs theme to to sphinx-immaterial theme. Fixes the issue with the logo and makes the site feel a little newer.
Fixes #22817