[docs] Add Presto C++ config properties doc#22885
[docs] Add Presto C++ config properties doc#22885aditi-pandit merged 1 commit intoprestodb:masterfrom
Conversation
|
Reviewers, please help me with the content - especially anything currently marked |
0560e17 to
03b5c77
Compare
|
Thank you @imjalpreet for the review! I have updated with a new (squashed) commit, and I believe I have addressed all your comments. Let me know if I missed anything. |
03b5c77 to
b8dc66e
Compare
|
@agrawalreetika, @majetideepak, @aditi-pandit, @imjalpreet, @tdcmeehan: Thanks for your quick reviews! I have addressed the feedback from everyone and pushed (and squashed) an update. I ask that you all take another look and re-review as you feel appropriate, please. |
b8dc66e to
531ed39
Compare
|
@agrawalreetika, @majetideepak, @aditi-pandit, @imjalpreet, @tdcmeehan - I have addressed the feedback from everyone as best I understand the consensus, and I have pushed (and squashed) an update. Please review the latest version and let me know what changes are needed. |
majetideepak
left a comment
There was a problem hiding this comment.
@steveburnett 2 comments.
531ed39 to
e8b25fd
Compare
|
@majetideepak and @aditi-pandit, I've revised addressing your most recent discussions. Let me know if you'd like any more changes, please. |
majetideepak
left a comment
There was a problem hiding this comment.
thanks, @steveburnett
|
@agrawalreetika, I believe I addressed all of your requested changes. Would you review this again and let me know if you want anything else? |
aditi-pandit
left a comment
There was a problem hiding this comment.
Thanks @steveburnett for the rewrites.
f2d0b67
e8b25fd to
f2d0b67
Compare
|
@majetideepak and @tdcmeehan, I have pushed a squashed commit update that removes the session properties from the doc. Take another look and let me know what you think, please. |
tdcmeehan
left a comment
There was a problem hiding this comment.
Thanks @steveburnett !
|
Thank you @agrawalreetika, @majetideepak, @aditi-pandit, @imjalpreet, and @tdcmeehan for your help! |
Description
Add documentation of Presto C++ configuration properties for coordinator and worker to existing Presto C++ documentation in Presto.
Motivation and Context
Fixes #22877.
Impact
Documentation.
Test Plan
Local docs build. Also CI.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.