Remove Metadata from RowExpressionInterpreter#22868
Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom May 31, 2024
Merged
Remove Metadata from RowExpressionInterpreter#22868tdcmeehan merged 1 commit intoprestodb:masterfrom
tdcmeehan merged 1 commit intoprestodb:masterfrom
Conversation
Contributor
Author
|
Our codeowner rules should have added @jaystarshot and @feilong-liu as reviewers for this PR. I will follow up why it did not. |
jaystarshot
approved these changes
May 30, 2024
Member
jaystarshot
left a comment
There was a problem hiding this comment.
LGTM, though I feel that metadata is always good to have
Member
Contributor
Author
|
Thanks @jaystarshot, I think you're right. Can you look at #22875? |
The only reference to the Metadata in RowExpressionInterpreter is to retrieve the FunctionAndTypeManager. However, the FunctionAndTypeManager actually doesn't even belong on the Metadata class and can be injected where needed. This refactoring reduces the call sites to Metadata#getFunctionAndTypeManager.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The only reference to the Metadata in RowExpressionInterpreter is to retrieve the FunctionAndTypeManager. However, the FunctionAndTypeManager actually doesn't even belong on the Metadata class and can be injected where needed. This refactoring reduces the call sites to Metadata#getFunctionAndTypeManager, and makes subsequent refactoring around RowExpressionInterpreter smaller and easier to understand.
Motivation and Context
Code cleanup and simplifying commits.
Impact
No external changes.
Test Plan
Existing tests are sufficient.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
If release note is NOT required, use: