Skip to content

[native] Add positional deletes to Iceberg native tpcds e2e tests #22867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yingsu00 merged 1 commit into from
Jul 4, 2024
Merged

[native] Add positional deletes to Iceberg native tpcds e2e tests #22867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ...cution/src/test/java/com/facebook/presto/nativeworker/AbstractTestNativeTpcdsQueries.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ public abstract class AbstractTestNativeTpcdsQueries
{
String storageFormat = "DWRF";
Session session;
String[] tpcdsFactTableNames = {"catalog_returns", "catalog_sales", "web_sales", "web_returns",
"inventory", "store_sales", "store_returns"};

@Override
protected void createTables()
Expand All @@ -41,7 +43,7 @@ protected void createTables()
.setSystemProperty(QUERY_MAX_RUN_TIME, "2m")
.setSystemProperty(QUERY_MAX_EXECUTION_TIME, "2m")
.build();

dropTables();
createTpcdsCallCenter(queryRunner, session, storageFormat);
createTpcdsCatalogPage(queryRunner, session);
createTpcdsCatalogReturns(queryRunner, session);
Expand All @@ -68,6 +70,13 @@ protected void createTables()
createTpcdsWebSite(queryRunner, session, storageFormat);
}

private void dropTables()
{
for (String table : tpcdsFactTableNames) {
assertUpdate(session, "DROP TABLE IF EXISTS " + table);
}
}

private static void createTpcdsCallCenter(QueryRunner queryRunner, Session session, String storageFormat)
{
if (!queryRunner.tableExists(session, "call_center")) {
Expand Down
Loading