[Native] Modify setup-adapters.sh to install prometheus-cpp#22857
Merged
majetideepak merged 1 commit intoprestodb:masterfrom May 30, 2024
Merged
[Native] Modify setup-adapters.sh to install prometheus-cpp#22857majetideepak merged 1 commit intoprestodb:masterfrom
majetideepak merged 1 commit intoprestodb:masterfrom
Conversation
Collaborator
majetideepak
left a comment
majetideepak
left a comment
There was a problem hiding this comment.
You have to include install_prometheus_cpp=1 in the 43-46 line block with comment
# Install all adapters by default
karteekmurthys
force-pushed
the
setup-prometheus-cpp
branch
from
dcbd196 to
8fa6d84
Compare
majetideepak
approved these changes
May 30, 2024
36 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds promtheus-cpp library dependency required by this PR: #22360.
Motivation and Context
This change is required to setup Circle CI images so that we can run the unit test defined in #22360.