Connector changes for time travel BEFORE clause.#22851
Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom Jun 5, 2024
Merged
Connector changes for time travel BEFORE clause.#22851tdcmeehan merged 1 commit intoprestodb:masterfrom
tdcmeehan merged 1 commit intoprestodb:masterfrom
Conversation
steveburnett
previously approved these changes
May 28, 2024
Contributor
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull branch, local docs build, everything looks good. Thanks!
Contributor
|
Suggest revising the release note entry following the Order of changes and Section naming topics in the Release Notes Guidelines. If the examples are valuable, suggest adding them to the Iceberg Connector documentation. |
6 tasks
Contributor
|
I overlooked "add PR # to the release note entry" in my previous comment, apologies for that! |
hantangwangd
reviewed
Jun 4, 2024
Member
hantangwangd
left a comment
There was a problem hiding this comment.
Thanks for the work, change looks good to me. Only one little thing in test.
presto-iceberg/src/test/java/com/facebook/presto/iceberg/TestIcebergTableVersion.java
Outdated
Show resolved
Hide resolved
cd3baae to
b3e95f8
Compare
steveburnett
approved these changes
Jun 4, 2024
Contributor
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull updated branch, review new local docs build, everything looks good. Thanks!
b3e95f8 to
734fc60
Compare
vivek-bharathan
approved these changes
Jun 4, 2024
tdcmeehan
approved these changes
Jun 5, 2024
36 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presto issue : #21971
Note - This PR has iceberg connector changes, test and doc update. Syntax change for "BEFORE" keyword in presto engine is already merged.
This feature will allow iceberg connector to query historical data using BEFORE syntax on a table.
Time travel version option will read bigint snapshot id value for the table. Time travel timestamp option will read
timestamp-with-time-zone value for the table.
Examples
Iceberg connector
Motivation and Context
Snowflake provides a BEFORE clause for time travel queries. When used in a query, this clause is specified in the FROM clause immediately after the table name. It determines the point in the past from which historical data is requested for the object. The AT keyword includes changes made by a statement or transaction with a timestamp equal to the specified parameter, while the BEFORE keyword refers to a point immediately preceding the specified parameter.
IBM Netezza supports BEFORE clause similar to Snowflake.
Impact
A new table level option to return specific snapshot for iceberg connector
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.