Move the description of Iceberg procedures to a dedicated subheading#22845
Move the description of Iceberg procedures to a dedicated subheading#22845tdcmeehan merged 1 commit intoprestodb:masterfrom
Conversation
| ======= | ||
| >>>>>>> Move the description of Iceberg procedures to a dedicated subheading |
There was a problem hiding this comment.
Here exists a conflict. Please handle it first.
There was a problem hiding this comment.
conflicts fixed.
|
@jackychen718 per our CONTRIBUTING.md, you need to make sure your commits are squashed. Please follow a resource on the internet if you don't know what this means--here is one article I found that may help. I'll mark this as draft, please take it out of draft once you've completed this, thanks! |
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
Nice work! A few nits and suggestions.
jackychen718
force-pushed
the
procedure-in-doc
branch
from
27eac10 to
6fe844f
Compare
jackychen718
force-pushed
the
procedure-in-doc
branch
from
6fe844f to
fa831dc
Compare
hantangwangd
left a comment
hantangwangd
left a comment
There was a problem hiding this comment.
Thanks for the fix. Change looks good to me. Please take this PR out of draft following @tdcmeehan 's guidance.
|
Looks good to me. @steveburnett would you like to have a look? |
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull updated branch, reviewed new build of doc, all comments addressed and no new concerns found. Thanks!
5 participants
According #22608:
Move the description of Iceberg procedures to a dedicated subheading.