added docs for noisy_approx_set_sfm_from_index_and_zeros#22799
Merged
steveburnett merged 1 commit intoprestodb:masterfrom May 21, 2024
Merged
Conversation
steveburnett
requested changes
May 21, 2024
Contributor
steveburnett
left a comment
There was a problem hiding this comment.
Really nice work! A few nits to consider.
2ea9f49 to
ae0daa7
Compare
Contributor
Author
|
@steveburnett OK, I made the changes, and clarified that if |
36 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added documentation for
noisy_approx_set_sfm_from_index_and_zerosto the new noisy approximation functions section added in #22715Motivation and Context
Documentation for this new function, as requested by #22508
Impact
Docs only
Test Plan
Build docs and inspect, verify links to reference PDFs in bibliography
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.