Skip to content

added docs for noisy_approx_set_sfm_from_index_and_zeros#22799

Merged
steveburnett merged 1 commit intoprestodb:masterfrom
fazalmajid:noisy_approx_set_sfm_from_index_and_zeros-doc
May 21, 2024
Merged

added docs for noisy_approx_set_sfm_from_index_and_zeros#22799
steveburnett merged 1 commit intoprestodb:masterfrom
fazalmajid:noisy_approx_set_sfm_from_index_and_zeros-doc

Conversation

@fazalmajid
Copy link
Contributor

Description

Added documentation for noisy_approx_set_sfm_from_index_and_zeros to the new noisy approximation functions section added in #22715

Motivation and Context

Documentation for this new function, as requested by #22508

Impact

Docs only

Test Plan

Build docs and inspect, verify links to reference PDFs in bibliography

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Add documentation for :func:`noisy_approx_set_sfm_from_index_and_zeros`

@fazalmajid fazalmajid requested review from a team and steveburnett as code owners May 21, 2024 16:27
@fazalmajid fazalmajid requested a review from presto-oss May 21, 2024 16:27
@github-actions github-actions bot added the docs label May 21, 2024
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work! A few nits to consider.

@fazalmajid fazalmajid force-pushed the noisy_approx_set_sfm_from_index_and_zeros-doc branch from 2ea9f49 to ae0daa7 Compare May 21, 2024 18:37
@fazalmajid
Copy link
Contributor Author

@steveburnett OK, I made the changes, and clarified that if col_zeros exceeds precision, it is cropped to precision-1

Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants