Support functionc call rewrite by Presto Verifier#22783
Merged
gggrace14 merged 1 commit intoprestodb:masterfrom May 28, 2024
Merged
Support functionc call rewrite by Presto Verifier#22783gggrace14 merged 1 commit intoprestodb:masterfrom
gggrace14 merged 1 commit intoprestodb:masterfrom
Conversation
steveburnett
requested changes
May 20, 2024
Contributor
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
Nice work, thanks! Nits of formatting suggested to improve readability.
Contributor
Author
Hi @steveburnett , I revised the .rst doc based on my understanding of the comments. Let me know if I miss anything. |
Contributor
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
Looks good! One tiny nit.
| where ``foo(c0, _)`` would be substituted by ``bar(c0)``, | ||
| with the declared arguments applied to the corresponding positions. | ||
|
|
||
| Concatenate function substitutions with comma. |
Contributor
There was a problem hiding this comment.
Suggested change
| Concatenate function substitutions with comma. | |
| Concatenate function substitutions with a comma. |
gggrace14
force-pushed
the
newfunction
branch
2 times, most recently
from
154a141 to
20d3a04
Compare
arhimondr
previously approved these changes
May 25, 2024
gggrace14
changed the title
Enable Presto Verifier to substitute function call expressions in a source query, according to the user specified substitution pattern, by the config function-substitutes. Support function call substitutions when rewriting Query, CreateTableAsSelect and Insert source queries.
steveburnett
approved these changes
May 28, 2024
Contributor
steveburnett
left a comment
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull updated branch, new local build, everything looks good. Thanks!
arhimondr
approved these changes
May 28, 2024
36 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable Presto Verifier to substitute function call expressions in a source query, according to the user specified substitution pattern, by the config function-substitutes. Support function call substitutions when rewriting Query, CreateTableAsSelect and Insert source queries.
Motivation and Context
Allow the Presto Verifier users to substitute functions, ex., nondeterministic functions, to make the test query comparable with TEST and CONTROL.
Impact
The feature is enabled only when the parameter --function-substitutes is set.
Test Plan
Unit tests in TestQueryRewriter.
Release Notes