Skip to content

[native] Remove spill stats reporting from presto native#22751

Merged
tanjialiang merged 1 commit intoprestodb:masterfrom
tanjialiang:rm_spill_stats
May 15, 2024
Merged

[native] Remove spill stats reporting from presto native#22751
tanjialiang merged 1 commit intoprestodb:masterfrom
tanjialiang:rm_spill_stats

Conversation

@tanjialiang
Copy link
Contributor

Removes spill related stats reporting from presto native. Migrated the reporting to velox's PeriodicStatsReporter.

== RELEASE NOTES ==
Since there are metrics removed from reporting, dashboards might be affected. Migrate the dashboard to point to the velox reported metrics instead.
The removed spill related metrics are going to be replaced by velox reported metrics in the following way:
original: presto_cpp.spill_metrics_name
new: velox.spill_metrics_name

@tanjialiang tanjialiang requested a review from a team as a code owner May 15, 2024 04:01
Copy link
Contributor

@xiaoxmeng xiaoxmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tanjialiang thanks!

@tanjialiang tanjialiang merged commit 6c682f5 into prestodb:master May 15, 2024
@wanglinsong wanglinsong mentioned this pull request Jun 25, 2024
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants