Skip to content

[native] Migrate away stats reporting for allocator and cache#22720

Merged
tanjialiang merged 1 commit intoprestodb:masterfrom
tanjialiang:rm_mem_stats
May 11, 2024
Merged

[native] Migrate away stats reporting for allocator and cache#22720
tanjialiang merged 1 commit intoprestodb:masterfrom
tanjialiang:rm_mem_stats

Conversation

@tanjialiang
Copy link
Contributor

@tanjialiang tanjialiang commented May 11, 2024

Migrate away allocator and cache related stats reporting as Velox's PeriodicStatsReporter already has it now.

== RELEASE NOTES ==

PeriodicTaskManager changes:
Removed stats reporting for memory allocator.
Removed stats reporting for in-memory cache and ssd cache.

The removed stats reporting could be found in PeriodicStatsReporter in velox. With the stats renamed from presto_cpp.<stats> to velox.<stats>.
Externally integrated dashboards and metrics monitoring system will need to change to the migrated velox reported metrics.

@tanjialiang tanjialiang requested a review from a team as a code owner May 11, 2024 03:34
@facebook-github-bot
Copy link
Collaborator

@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@xiaoxmeng xiaoxmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tanjialiang LGTM. Thanks!

@facebook-github-bot
Copy link
Collaborator

@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Collaborator

@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@tanjialiang tanjialiang merged commit d9114d3 into prestodb:master May 11, 2024
@wanglinsong wanglinsong mentioned this pull request Jun 25, 2024
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants