Adjust split weights by actual data read#22635
Merged
pranjalssh merged 1 commit intoprestodb:masterfrom Apr 30, 2024
Merged
Conversation
arhimondr
approved these changes
Apr 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently added dynamic split sizes support in #22051
This would result in larger split sizes when Presto doesn't really read all of the split.
However, this would also assign large split weights(as they are based on sizes) than earlier - which could mess with some of the weighted split scheduling configs.
This readjusts the split weight to the actual data that the presto worker will read.