Fix correctness issue in regr_r2#22611
Conversation
mbasmanova
left a comment
There was a problem hiding this comment.
@8dukongjian Thank you for the fix.
CC @tdcmeehan
mbasmanova
left a comment
There was a problem hiding this comment.
@8dukongjian Would you update comment message to follow the guidelines?
There are two special cases: 1. m2X() = 0, then result should be NULL 2. m2X() != 0 and m2Y() = 0, then result shoule be 1.
Thanks, updated. |
mbasmanova
left a comment
There was a problem hiding this comment.
@8dukongjian Thank you for adding details to the commit message. There is some broken English in the title. Would you update as well? Thanks.
Fix regr_r2 result incorrect
Fix correctness issue in regr_r2
|
CC: @steveburnett |
|
Maybe the following changes to the release note entry: @mbasmanova, is there anything else I can help with here? |
|
@8dukongjian Please, help fix commit message here: https://github.com/prestodb/presto/pull/22611/commits |
|
@steveburnett Steve, thank you for looking. Wanted to FYI you because this is a user-visible change in behavior and requires an RN. |
tdcmeehan
left a comment
There was a problem hiding this comment.
Thanks for the fix @8dukongjian. @wanglinsong can we add this to 0.287?
Thank you for your comments. Sorry, I was too busy recently and forgot to fix it. |
I cherry-picked it into the |
Description
Fix regr_r2 result incorrect. There are two special cases:
Found by facebookincubator/velox#9522
Release Notes
Please follow release notes guidelines and fill in the release notes below.