[Iceberg]Support metadata delete with predicate on non-identity partition columns#22554
Merged
hantangwangd merged 1 commit intoprestodb:masterfrom May 14, 2024
Conversation
34e4d6e to
43323bf
Compare
43323bf to
2eea744
Compare
2eea744 to
6c0406a
Compare
tdcmeehan
approved these changes
May 14, 2024
36 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
in PR #21999, we have supported pushing down thoroughly the predicates on non-identity partition columns if they align with partitioning boundaries. So we can as well support the metadata delete on such predicates based on the same judgement logic.
Motivation and Context
Metadata-based deletion performs better than row-based deletion, and it do not corrupt the Iceberg data file metrics, so we should use it whenever possible.
Test Plan
Contributor checklist
Release Notes