[native] Centralize sslcontext creation.#22378
Merged
amitkdutta merged 1 commit intoprestodb:masterfrom Mar 31, 2024
Merged
Conversation
amitkdutta
changed the title
xiaoxmeng
approved these changes
Mar 31, 2024
Contributor
xiaoxmeng
left a comment
xiaoxmeng
left a comment
There was a problem hiding this comment.
@amitkdutta LGTM. Thanks!
48 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently SSL context creation code is duplicated between PrestoServer and tests. This can led to a situation where tests create context in a different way than server, and thus skipping server's sslcontext creation code path. Here we centralize sslcontext creation, so that server and tests use exactly same code path.