[native] Retrieve Json function metadata for prestissimo functions by pramodsatya · Pull Request #22332 · prestodb/presto

pramodsatya · 2024-03-26T05:16:47Z

Motivation and Context

For fail fast function validation in Prestissimo, the coordinator needs to know the list of function signatures that are supported by Prestissimo. This is so we can validate during parsing and analysis that a function is supported. In order to expose this, a new HTTP method is added that returns the function signatures supported by the Prestissimo worker.

The format of the functions should be a map of name to function signature. Name is a simple string. Function signature is a JSON object which matches the format of JsonBasedUdfFunctionMetadata in the Java code. All functions currently come from Velox, hence we need to retrieve the list of supported functions in Velox. This map is translated to a format that conforms to JsonBasedUdfFunctionMetadata and is serialized to JSON for consumption by the Java coordinator.

Description

For full context, see #23000

This PR adds a http endpoint /v1/functions to the sidecar, which returns the list of function signatures conforming to format JsonBasedUdfFunctionMetadata for all the registered Presto native functions.

Test Plan

Unit tests are added in FunctionMetadataTest.cpp. E2E tests will be added in a followup PR

== NO RELEASE NOTE ==

aditi-pandit · 2024-06-13T00:55:52Z

@pramodsatya : Please give more information about how this http method will be used in Presto server.

presto-native-execution/presto_cpp/main/types/FunctionMetadata.h

presto-native-execution/presto_cpp/main/types/tests/FunctionMetadataTest.cpp

presto-native-execution/presto_cpp/main/types/FunctionMetadata.cpp

pramodsatya

Thanks for the feedback @aditi-pandit, addressed the review comments. Could you please take another look?

mbasmanova

@pramodsatya Would you document the new endpoint somewhere in https://prestodb.io/docs/current/develop/worker-protocol.html ?

tdcmeehan · 2024-08-02T02:13:41Z

@mbasmanova we have started to document our endpoints using OpenAPI, and eventually all sidecar endpoints (and, hopefully all Presto endpoints) will have corresponding OpenAPI documentation.

mbasmanova · 2024-08-02T03:02:29Z

we have started to document our endpoints using OpenAPI, and eventually all sidecar endpoints (and, hopefully all Presto endpoints) will have corresponding OpenAPI documentation.

Sounds cool. Where can I see docs for the new endpoint?

aditi-pandit

@pramodsatya : The changes look good. Please add more test cases though... We should cover functions with different types, template parameters, array, map functions as well.

presto-native-execution/presto_cpp/presto_protocol/presto_protocol.yml

presto-native-execution/presto_cpp/main/types/FunctionMetadata.cpp

presto-native-execution/presto_cpp/main/types/tests/FunctionMetadataTest.cpp

steveburnett

Thanks for the doc! Pulled branch and made a local docs build. Some nits of capitalization, everything else looks fine.

presto-docs/src/main/sphinx/develop/worker-protocol.rst

czentgr

Thanks, I have a few comments.

presto-docs/src/main/sphinx/develop/sidecar-protocol.rst

presto-native-execution/presto_cpp/main/PrestoServer.cpp

presto-native-execution/presto_cpp/main/types/tests/CMakeLists.txt

presto-native-execution/presto_cpp/presto_protocol/presto_protocol.yml

presto-native-execution/presto_cpp/presto_protocol/special/Language.cpp.inc

pramodsatya · 2024-08-03T02:21:32Z

Thanks, I have a few comments.

Thanks for the feedback @czentgr, I have addressed the comments. Could you please take another look?

aditi-pandit · 2024-08-22T16:13:26Z

@pramodsatya : Please can you rebase your code. I'll continue with the review then.

pramodsatya · 2024-08-22T23:11:28Z

@pramodsatya : Please can you rebase your code. I'll continue with the review then.

Thanks @aditi-pandit, rebased and fixed the CI failures.

aditi-pandit · 2024-09-06T05:53:07Z

presto-native-execution/presto_cpp/presto_protocol/presto_protocol.yml

  - presto-main/src/main/java/com/facebook/presto/connector/system/SystemColumnHandle.java
  - presto-main/src/main/java/com/facebook/presto/connector/system/SystemTableLayoutHandle.java
-  - presto-main/src/main/java/com/facebook/presto/connector/system/SystemTransactionHandle.java
+  - presto-main/src/main/java/com/facebook/presto/connector/system/SystemTransactionHandle.java


Agree that there isn't particular organization in this file. But we should make it in alphabetical order. Will send out a PR for it.

presto-native-execution/presto_cpp/main/types/FunctionMetadata.cpp

presto-native-execution/presto_cpp/main/types/tests/FunctionMetadataTest.cpp

aditi-pandit · 2024-09-25T05:59:50Z

@pramodsatya : This code looks good.

@czentgr : Would be great if you did a pass as well. Will give approval once you give a heads-up.

czentgr

One thought and one nit.

presto-native-execution/presto_cpp/main/PrestoServer.cpp

presto-native-execution/presto_cpp/main/types/FunctionMetadata.cpp

pramodsatya

Thanks for the feedback @czentgr @aditi-pandit. Consolidated the sidecar endpoints to a single function, also added a helper function to identify and exclude function signatures with unsupported Presto types (hugeint is currently unsupported in Presto). Could you please take another look?

presto-native-execution/presto_cpp/main/PrestoServer.cpp

aditi-pandit

@pramodsatya : Have 2 minor comments. Rest is looking good.

presto-native-execution/presto_cpp/main/PrestoServer.cpp

presto-native-execution/presto_cpp/main/types/tests/TestUtils.cpp

pramodsatya

Thanks for the feedback @aditi-pandit, addressed the comments. Could you please take another look?

presto-native-execution/presto_cpp/main/types/tests/TestUtils.cpp

aditi-pandit

Thanks @pramodsatya

Please can you also add a link to the documentation of the API.

pdabre12 · 2024-10-21T17:13:04Z

@aditi-pandit
The OpenAPI documentation for the endpoint should be added in this PR: #23358

pramodsatya requested review from aditi-pandit, czentgr and tdcmeehan March 26, 2024 05:16

pramodsatya mentioned this pull request Mar 26, 2024

feat: Add companionFunction to function metadata facebookincubator/velox#9250

Closed

pramodsatya force-pushed the fn_metadata branch from 3e2eac3 to 330b340 Compare March 26, 2024 16:11

pramodsatya force-pushed the fn_metadata branch from 330b340 to 6386575 Compare April 24, 2024 19:57

pramodsatya changed the title ~~[WIP] [native] Retrieve Json function metadata for prestissimo functions~~ [native] Retrieve Json function metadata for prestissimo functions Jun 7, 2024

pramodsatya force-pushed the fn_metadata branch from 6386575 to bd8b27f Compare June 7, 2024 16:12

aditi-pandit reviewed Jun 13, 2024

View reviewed changes

pramodsatya force-pushed the fn_metadata branch from bd8b27f to edd9e93 Compare August 2, 2024 00:34

pramodsatya marked this pull request as ready for review August 2, 2024 00:34

pramodsatya requested a review from a team as a code owner August 2, 2024 00:34

pramodsatya force-pushed the fn_metadata branch from edd9e93 to 0cf2dd5 Compare August 2, 2024 01:15

pramodsatya commented Aug 2, 2024

View reviewed changes

mbasmanova reviewed Aug 2, 2024

View reviewed changes

pramodsatya force-pushed the fn_metadata branch from 0cf2dd5 to 27d780d Compare August 2, 2024 01:59

pramodsatya requested review from a team, elharo and steveburnett as code owners August 2, 2024 01:59

pramodsatya requested a review from presto-oss August 2, 2024 01:59

aditi-pandit reviewed Aug 2, 2024

View reviewed changes

steveburnett requested changes Aug 2, 2024

View reviewed changes

presto-docs/src/main/sphinx/develop/worker-protocol.rst Outdated Show resolved Hide resolved

presto-docs/src/main/sphinx/develop/worker-protocol.rst Outdated Show resolved Hide resolved

presto-docs/src/main/sphinx/develop/worker-protocol.rst Outdated Show resolved Hide resolved

tdcmeehan requested changes Aug 2, 2024

View reviewed changes

presto-docs/src/main/sphinx/develop/worker-protocol.rst Outdated Show resolved Hide resolved

presto-docs/src/main/sphinx/develop/worker-protocol.rst Outdated Show resolved Hide resolved

presto-docs/src/main/sphinx/develop/worker-protocol.rst Outdated Show resolved Hide resolved

pramodsatya force-pushed the fn_metadata branch from 27d780d to 90dd09f Compare August 2, 2024 19:27

czentgr reviewed Aug 2, 2024

View reviewed changes

pramodsatya force-pushed the fn_metadata branch from 90dd09f to a006c3e Compare August 3, 2024 02:20

pramodsatya force-pushed the fn_metadata branch 2 times, most recently from 4ed8961 to 56813d3 Compare August 22, 2024 21:46

pramodsatya force-pushed the fn_metadata branch from 56813d3 to da222f9 Compare August 27, 2024 21:51

pramodsatya requested review from aditi-pandit, czentgr and tdcmeehan August 27, 2024 21:57

pramodsatya force-pushed the fn_metadata branch from da222f9 to 88c8b7a Compare August 27, 2024 22:08

aditi-pandit reviewed Sep 9, 2024

View reviewed changes

pramodsatya force-pushed the fn_metadata branch from 88c8b7a to 568e1cf Compare September 10, 2024 01:12

czentgr reviewed Sep 27, 2024

View reviewed changes

presto-native-execution/presto_cpp/main/PrestoServer.cpp Outdated Show resolved Hide resolved

presto-native-execution/presto_cpp/main/types/FunctionMetadata.cpp Outdated Show resolved Hide resolved

pramodsatya force-pushed the fn_metadata branch from 568e1cf to d716ca2 Compare September 30, 2024 00:42

pramodsatya commented Sep 30, 2024

View reviewed changes

presto-native-execution/presto_cpp/main/PrestoServer.cpp Outdated Show resolved Hide resolved

pramodsatya force-pushed the fn_metadata branch from d716ca2 to 37deb95 Compare September 30, 2024 00:50

pramodsatya requested review from aditi-pandit and czentgr October 4, 2024 02:40

aditi-pandit reviewed Oct 12, 2024

View reviewed changes

presto-native-execution/presto_cpp/main/PrestoServer.cpp Show resolved Hide resolved

presto-native-execution/presto_cpp/main/types/tests/TestUtils.cpp Outdated Show resolved Hide resolved

pramodsatya added 2 commits October 17, 2024 10:09

[native] Update presto_protocol

25a996c

[native] Retrieve Json function metadata

11c83e3

pramodsatya force-pushed the fn_metadata branch from 37deb95 to 11c83e3 Compare October 17, 2024 15:17

pramodsatya commented Oct 17, 2024

View reviewed changes

presto-native-execution/presto_cpp/main/types/tests/TestUtils.cpp Outdated Show resolved Hide resolved

aditi-pandit approved these changes Oct 19, 2024

View reviewed changes

tdcmeehan approved these changes Oct 20, 2024

View reviewed changes

pramodsatya merged commit bba64ad into prestodb:master Oct 21, 2024

pramodsatya deleted the fn_metadata branch October 21, 2024 17:39

zuyu mentioned this pull request Oct 22, 2024

[native] Update gtest targets for presto_function_metadata_test #23866

Merged

pramodsatya mentioned this pull request Feb 4, 2025

[native] Detect companion functions from velox function metadata #24482

Merged

Conversation

pramodsatya commented Mar 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation and Context

Description

Test Plan

Uh oh!

aditi-pandit commented Jun 13, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pramodsatya left a comment

Choose a reason for hiding this comment

Uh oh!

mbasmanova left a comment

Choose a reason for hiding this comment

Uh oh!

tdcmeehan commented Aug 2, 2024

Uh oh!

mbasmanova commented Aug 2, 2024

Uh oh!

aditi-pandit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

steveburnett left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

czentgr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pramodsatya commented Aug 3, 2024

Uh oh!

aditi-pandit commented Aug 22, 2024

Uh oh!

pramodsatya commented Aug 22, 2024

Uh oh!

aditi-pandit Sep 6, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aditi-pandit commented Sep 25, 2024

Uh oh!

czentgr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pramodsatya commented Mar 26, 2024 •

edited

Loading

aditi-pandit left a comment •

edited

Loading