Fix memory revoke in TopNRowNumberOperator#22281
Merged
hantangwangd merged 1 commit intoprestodb:masterfrom Mar 22, 2024
Merged
Fix memory revoke in TopNRowNumberOperator#22281hantangwangd merged 1 commit intoprestodb:masterfrom
TopNRowNumberOperator#22281hantangwangd merged 1 commit intoprestodb:masterfrom
Conversation
elharo
approved these changes
Mar 21, 2024
rschlussel
approved these changes
Mar 21, 2024
Contributor
|
This should have a release note. it fixes a bug with spilling in TopNRowNumber |
Member
Author
OK, done. |
tdcmeehan
approved these changes
Mar 21, 2024
36f1401 to
54e4af6
Compare
48 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #22127 .
TopNRowNumberOperatorshould not simply return a completed future forstartMemoryRevoke()when it's flagfinishingis true. That could lead in the problem described in #22127 when events occur in following order:finish()method is called by upstream operator, and the flagmemoryRevokingRequestedis set byMemoryRevokingScheduler.handleMemoryRevoke(), the error above would appear.Test Plan
TestDistributedSpilledQueriesWithTempStorage.testRowNumberLimitContributor checklist
Release Notes