Prevent removal of aggregation nodes when grouping sets are present#22224
Merged
vivek-bharathan merged 1 commit intoprestodb:masterfrom Mar 19, 2024
Merged
Prevent removal of aggregation nodes when grouping sets are present#22224vivek-bharathan merged 1 commit intoprestodb:masterfrom
vivek-bharathan merged 1 commit intoprestodb:masterfrom
Conversation
vivek-bharathan
requested review from
ZacBlanco,
aaneja,
feilong-liu and
presto-oss
aaneja
reviewed
Mar 18, 2024
presto-main/src/test/java/com/facebook/presto/sql/planner/TestLogicalPlanner.java
Show resolved
Hide resolved
| exploitConstraints, | ||
| anyTree( | ||
| node(AggregationNode.class, | ||
| node(ProjectNode.class, |
Contributor
There was a problem hiding this comment.
nit : The Project node isn't strictly necessary. It's only added because optimizer_hash_generation is on
...in/java/com/facebook/presto/sql/planner/iterative/rule/RemoveRedundantAggregateDistinct.java
Show resolved
Hide resolved
...in/java/com/facebook/presto/sql/planner/iterative/rule/RemoveRedundantAggregateDistinct.java
Show resolved
Hide resolved
feilong-liu
reviewed
Mar 18, 2024
Contributor
feilong-liu
left a comment
feilong-liu
left a comment
There was a problem hiding this comment.
LG.
For the unit tests, I think they need to be put in a separate test class corresponding to the optimizer itself.
ZacBlanco
approved these changes
Mar 19, 2024
ZacBlanco
previously approved these changes
Mar 19, 2024
Contributor
ZacBlanco
left a comment
ZacBlanco
left a comment
There was a problem hiding this comment.
Agree with Anant on moving the tests. Otherwise LGTM
vivek-bharathan
force-pushed
the
constraintsbug
branch
2 times, most recently
from
697146f to
ce55324
Compare
feilong-liu
approved these changes
Mar 19, 2024
aaneja
approved these changes
Mar 19, 2024
tdcmeehan
approved these changes
Mar 19, 2024
vivek-bharathan
force-pushed
the
constraintsbug
branch
from
ce55324 to
cd91a5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #22171
If release note is NOT required, use: