Track bytes read even when its a FragmentResultCache hit#22145
Track bytes read even when its a FragmentResultCache hit#22145NikhilCollooru merged 1 commit intoprestodb:masterfrom
Conversation
1e2c750 to
087a5e1
Compare
087a5e1 to
5efccf9
Compare
|
The numbers are not reported correctly even after this change. There is some bug, still need to fix it. with 0% FRC cache hit rate : 20240322_172109_00004_ay76e (input size: 2.29GB , input rows : 16,622,497) |
presto-main/src/main/java/com/facebook/presto/operator/Driver.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/operator/Driver.java
Outdated
Show resolved
Hide resolved
|
@NikhilCollooru Is there an easy way to test and reproduce this? I wanted to use this to debug. |
38398b4 to
3dbe3c7
Compare
|
The trick is to use |
3dbe3c7 to
2f59111
Compare
presto-main/src/main/java/com/facebook/presto/operator/FileFragmentResultCacheConfig.java
Show resolved
Hide resolved
|
@NikhilCollooru Can we add a test cases which verifies the input data size? |
…esult cache Currently, the input bytes read for a query are reported as 0 when there is a 100% fragment result cache hit. But for some usecases its helpful to report the input data size even when its a fragment result cache hit. This PR adds support to track the input data size for every fragment we cache.
2f59111 to
1c79c4a
Compare
done. |
Description
Track bytes read even when its a FragmentResultCache hit
Motivation and Context
Currently, the input bytes, positions read for a query are reported
as 0 when there is a 100% fragment result cache hit. But for some
usecases its helpful to report the input data size even when its
a fragment result cache hit.
This PR adds support to track the input data size for every fragment
we cache.
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.