Skip to content

[WIP] Make PRIMARY a non-reserved keyword#22114

Closed
tdcmeehan wants to merge 1 commit intoprestodb:masterfrom
tdcmeehan:primary
Closed

[WIP] Make PRIMARY a non-reserved keyword#22114
tdcmeehan wants to merge 1 commit intoprestodb:masterfrom
tdcmeehan:primary

Conversation

@tdcmeehan
Copy link
Contributor

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* ...
* ...

Hive Changes
* ...
* ...

If release note is NOT required, use:

== NO RELEASE NOTE ==

@tdcmeehan tdcmeehan requested a review from a team as a code owner March 7, 2024 16:44
@tdcmeehan tdcmeehan requested a review from presto-oss March 7, 2024 16:44
@github-actions
Copy link

github-actions bot commented Mar 7, 2024

Codenotify: Notifying subscribers in CODENOTIFY files for diff 21340d8...b94c2c5.

Notify File(s)
@aditi-pandit presto-parser/src/main/antlr4/com/facebook/presto/sql/parser/SqlBase.g4
@elharo presto-parser/src/main/antlr4/com/facebook/presto/sql/parser/SqlBase.g4
@kaikalur presto-parser/src/main/antlr4/com/facebook/presto/sql/parser/SqlBase.g4
@rschlussel presto-parser/src/main/antlr4/com/facebook/presto/sql/parser/SqlBase.g4
@steveburnett presto-docs/src/main/sphinx/language/reserved.rst

Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)
Pull branch, new local build, everything looks good.

@tdcmeehan
Copy link
Contributor Author

Closed in favor of #22115

@tdcmeehan tdcmeehan closed this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants