Fix the issue where query with DistinctLimit failed due to turning on delete as join optimization#22106
Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom Mar 8, 2024
Merged
Conversation
3386321 to
1d4235e
Compare
elharo
approved these changes
Mar 7, 2024
jasonf20
approved these changes
Mar 7, 2024
Collaborator
There was a problem hiding this comment.
nit: I think it's a little cleaner to use !IcebergMetadataColumn.isMetadataColumnId here
Contributor
Author
There was a problem hiding this comment.
!IcebergMetadataColumn.isMetadataColumnId doesn't work here, Because the value of variableReferenceExpression#name is similar to $data_sequence_number_7.
Collaborator
There was a problem hiding this comment.
Ah you only have the variable references. I guess it's fine like this 👍
tdcmeehan
reviewed
Mar 7, 2024
Contributor
tdcmeehan
left a comment
There was a problem hiding this comment.
LGTM. Please reword the commit message. Perhaps
Fix equality delete with DistinctLimit
CONTEXT
tdcmeehan
approved these changes
Mar 8, 2024
48 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
com.facebook.presto.iceberg.optimizer.IcebergEqualityDeleteAsJoin.DeleteAsJoinRewriter#visitTableScanreturnsFilterNode's outputVariables will contain the$data_sequence_numbercolumn from the table on the right side of ConnectorJoinNode, An exception occurs when the parent of the returnedFilterNodeis aDistinctLimitNode.In fact, the $data_sequence_number column is only used in the FilterNode node, and its parent node is not used. This PR adds a ProjectNode on FilterNode that filters out the
$data_sequence_numbercolumn.Fixes #22105
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
CC: @tdcmeehan @yingsu00 @jasonf20