Add experimental noisyCardinality function#22087
Merged
pranjalssh merged 1 commit intoprestodb:masterfrom Mar 8, 2024
Merged
Conversation
Return a random noisy estimate of cardinality with new noisyCardinality(serializedHll, epsilon) function
elharo
reviewed
Mar 5, 2024
Contributor
elharo
left a comment
There was a problem hiding this comment.
a new function should probably have releases notes.
Contributor
Thanks! This PR is related to #21290. We're expecting to have documentation and release notes to provide in a follow-up PR soon. |
Contributor
|
If it's marked experimental, it does not show up in |
jonhehir
approved these changes
Mar 8, 2024
pranjalssh
approved these changes
Mar 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add noisyCardinality function for experimentation.
Motivation and Context
Unlike cardinality(HyperLogLog), which returns a deterministic approximate count, the noisy_cardinailty(HyperLogLog) function can be used to return a random noisy estimate of cardinality from a HyperLogLog sketch, similar to the random noisy estimates that would be returned from noisy_approx_distinct_sfm.
Impact
No impact to existing code since we are adding a new function.
Test Plan
Contributor checklist
Release Notes