Fix triggering of RcFilePageSourceFactory logic for non-RC tables#22066
Closed
sdruzkin wants to merge 1 commit intoprestodb:masterfrom
Closed
Fix triggering of RcFilePageSourceFactory logic for non-RC tables#22066sdruzkin wants to merge 1 commit intoprestodb:masterfrom
sdruzkin wants to merge 1 commit intoprestodb:masterfrom
Conversation
elharo
reviewed
Mar 2, 2024
Contributor
elharo
left a comment
There was a problem hiding this comment.
This seems significant enough a fix to justify an issue, release notes, and a test.
Collaborator
Author
This will only manifest itself if the order of page source factories in connector is such that ORC and Parquet are coming after the RC, meaning that you won't find it on a typical deployment. I found it after making Alpha page source factory compatible with the partial aggregation. |
Contributor
|
this should be fixed by #22011 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Logic in RcFilePageSourceFactory must be only applicable for RC tables.
However in the current implementation the RcFilePageSourceFactory logic
for checking partially aggregation pushdowns is triggered before making
sure the table has RC format. As result if ORC or Parquet batch reader factories
are placed after the RC factory, then the logic in the RC factory will incorrectly
fail the query.
Motivation and Context
See description.
Impact
No impact.
Test Plan
Existing tests.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.