Document Iceberg connector supported data types mapping #21998
Document Iceberg connector supported data types mapping #21998sbabtiwa wants to merge 9 commits intoprestodb:masterfrom
Conversation
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff ece7741...230c640.
|
hantangwangd
left a comment
There was a problem hiding this comment.
Thanks for the document supplement. Some little nits.
|
Thanks for this! A local build of the docs looks good in terms of formatting and general docs concerns. I'll wait to review and approve until after @hantangwangd's comments are addressed. Tag me in a comment or request a review from me when this is ready! |
|
Hi @hantangwangd, @steveburnett, and @tdcmeehan, I have modified the Iceberg connector type mapping documentation to implement the comments above and make the content more original. Please let me know if additional changes are needed. Thanks |
|
@hantangwangd, I have modified the STRUCT/ROW and vice versa type mapping in the branch. |
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pull updated branch, new local build. Thanks!
hantangwangd
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the fix!
tdcmeehan
left a comment
There was a problem hiding this comment.
Please squash commits and make sure the commit message adheres to our guidelines (linked in the commit checklist in your PR)
This reverts commit 4df5cc0.
|
@tdcmeehan, I ran into issues while squashing commits in my original branch, so I moved the single commit into a recreated branch. As a result, I had to open a new PR: #22093. Sorry for the inconvenience. |
Description
Added documentation for supported Iceberg connector data types mapping.
Motivation and Context
This change is required to help users understand which PrestoDB and Iceberg data types successfully map to each other.
This issue fixes 21848.
Impact
Adding documentation to Presto Docs iceberg.rst file.
Test Plan
Tested changes by building and viewing the Presto documentation.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.