Skip to content

Document Iceberg connector supported data types mapping #21998

Closed
sbabtiwa wants to merge 9 commits intoprestodb:masterfrom
sbabtiwa:issue21848
Closed

Document Iceberg connector supported data types mapping #21998
sbabtiwa wants to merge 9 commits intoprestodb:masterfrom
sbabtiwa:issue21848

Conversation

@sbabtiwa
Copy link
Contributor

Description

Added documentation for supported Iceberg connector data types mapping.

Motivation and Context

This change is required to help users understand which PrestoDB and Iceberg data types successfully map to each other.

This issue fixes 21848.

Impact

Adding documentation to Presto Docs iceberg.rst file.

Test Plan

Tested changes by building and viewing the Presto documentation.

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Add documentation for supported data types mapping in the Iceberg connector.

@sbabtiwa sbabtiwa requested a review from a team as a code owner February 23, 2024 22:47
@sbabtiwa sbabtiwa requested a review from presto-oss February 23, 2024 22:47
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 23, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions
Copy link

github-actions bot commented Feb 23, 2024

Codenotify: Notifying subscribers in CODENOTIFY files for diff ece7741...230c640.

Notify File(s)
@steveburnett presto-docs/src/main/sphinx/connector/iceberg.rst

@github-actions github-actions bot added the docs label Feb 23, 2024
Copy link
Member

@hantangwangd hantangwangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the document supplement. Some little nits.

@steveburnett
Copy link
Contributor

Thanks for this! A local build of the docs looks good in terms of formatting and general docs concerns. I'll wait to review and approve until after @hantangwangd's comments are addressed. Tag me in a comment or request a review from me when this is ready!

@sbabtiwa
Copy link
Contributor Author

Hi @hantangwangd, @steveburnett, and @tdcmeehan,

I have modified the Iceberg connector type mapping documentation to implement the comments above and make the content more original. Please let me know if additional changes are needed.

Thanks

Copy link
Member

@hantangwangd hantangwangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still little nits

@sbabtiwa
Copy link
Contributor Author

sbabtiwa commented Mar 1, 2024

@hantangwangd, I have modified the STRUCT/ROW and vice versa type mapping in the branch.

steveburnett
steveburnett previously approved these changes Mar 1, 2024
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull updated branch, new local build. Thanks!

hantangwangd
hantangwangd previously approved these changes Mar 1, 2024
Copy link
Member

@hantangwangd hantangwangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

Copy link
Contributor

@tdcmeehan tdcmeehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash commits and make sure the commit message adheres to our guidelines (linked in the commit checklist in your PR)

@tdcmeehan tdcmeehan self-assigned this Mar 4, 2024
@sbabtiwa sbabtiwa dismissed stale reviews from hantangwangd and steveburnett via 4df5cc0 March 5, 2024 20:03
@sbabtiwa sbabtiwa requested review from a team and shrinidhijoshi as code owners March 5, 2024 20:03
@github-actions github-actions bot removed the docs label Mar 5, 2024
@github-actions github-actions bot added the docs label Mar 5, 2024
@sbabtiwa sbabtiwa closed this Mar 5, 2024
@sbabtiwa sbabtiwa deleted the issue21848 branch March 5, 2024 20:58
@sbabtiwa
Copy link
Contributor Author

sbabtiwa commented Mar 5, 2024

@tdcmeehan, I ran into issues while squashing commits in my original branch, so I moved the single commit into a recreated branch. As a result, I had to open a new PR: #22093. Sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

[Doc] Document supported data types mapping in Iceberg connector

4 participants