Optimize repeat function by creating runlength block #21984
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,142 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.facebook.presto.operator.scalar; | ||
|
|
||
| import com.facebook.presto.common.Page; | ||
| import com.facebook.presto.common.type.ArrayType; | ||
| import com.facebook.presto.common.type.Type; | ||
| import com.facebook.presto.metadata.MetadataManager; | ||
| import com.facebook.presto.operator.DriverYieldSignal; | ||
| import com.facebook.presto.operator.project.PageProcessor; | ||
| import com.facebook.presto.spi.function.FunctionHandle; | ||
| import com.facebook.presto.spi.relation.CallExpression; | ||
| import com.facebook.presto.spi.relation.ConstantExpression; | ||
| import com.facebook.presto.spi.relation.RowExpression; | ||
| import com.facebook.presto.sql.gen.ExpressionCompiler; | ||
| import com.facebook.presto.sql.gen.PageFunctionCompiler; | ||
| import com.google.common.collect.ImmutableList; | ||
| import org.openjdk.jmh.annotations.Benchmark; | ||
| import org.openjdk.jmh.annotations.BenchmarkMode; | ||
| import org.openjdk.jmh.annotations.Fork; | ||
| import org.openjdk.jmh.annotations.Measurement; | ||
| import org.openjdk.jmh.annotations.Mode; | ||
| import org.openjdk.jmh.annotations.OperationsPerInvocation; | ||
| import org.openjdk.jmh.annotations.OutputTimeUnit; | ||
| import org.openjdk.jmh.annotations.Param; | ||
| import org.openjdk.jmh.annotations.Scope; | ||
| import org.openjdk.jmh.annotations.Setup; | ||
| import org.openjdk.jmh.annotations.State; | ||
| import org.openjdk.jmh.annotations.Warmup; | ||
| import org.openjdk.jmh.runner.Runner; | ||
| import org.openjdk.jmh.runner.options.Options; | ||
| import org.openjdk.jmh.runner.options.OptionsBuilder; | ||
| import org.openjdk.jmh.runner.options.VerboseMode; | ||
| import org.openjdk.jmh.runner.options.WarmupMode; | ||
|
|
||
| import java.util.List; | ||
| import java.util.Optional; | ||
| import java.util.concurrent.TimeUnit; | ||
|
|
||
| import static com.facebook.presto.common.type.IntegerType.INTEGER; | ||
| import static com.facebook.presto.memory.context.AggregatedMemoryContext.newSimpleAggregatedMemoryContext; | ||
| import static com.facebook.presto.metadata.MetadataManager.createTestMetadataManager; | ||
| import static com.facebook.presto.sql.analyzer.TypeSignatureProvider.fromTypes; | ||
| import static com.facebook.presto.testing.TestingConnectorSession.SESSION; | ||
|
|
||
| @SuppressWarnings("MethodMayBeStatic") | ||
| @State(Scope.Thread) | ||
| @OutputTimeUnit(TimeUnit.NANOSECONDS) | ||
| @Fork(2) | ||
| @Warmup(iterations = 10, time = 500, timeUnit = TimeUnit.MILLISECONDS) | ||
| @Measurement(iterations = 10, time = 500, timeUnit = TimeUnit.MILLISECONDS) | ||
| @BenchmarkMode(Mode.AverageTime) | ||
| public class BenchmarkRepeatFunction | ||
| { | ||
| private static final int POSITIONS = 1000; | ||
|
|
||
| public static void main(String[] args) | ||
| throws Throwable | ||
| { | ||
| // assure the benchmarks are valid before running | ||
| BenchmarkData data = new BenchmarkData(); | ||
| data.setup(); | ||
| new BenchmarkRepeatFunction().benchmark(data); | ||
|
|
||
| Options options = new OptionsBuilder() | ||
| .verbosity(VerboseMode.NORMAL) | ||
| .warmupMode(WarmupMode.INDI) | ||
| .include(".*" + BenchmarkRepeatFunction.class.getSimpleName() + ".*") | ||
| .build(); | ||
| new Runner(options).run(); | ||
| } | ||
|
|
||
| @Benchmark | ||
| @OperationsPerInvocation(POSITIONS) | ||
| public List<Optional<Page>> benchmark(BenchmarkData data) | ||
| { | ||
| return ImmutableList.copyOf( | ||
| data.getPageProcessor().process( | ||
| SESSION.getSqlFunctionProperties(), | ||
| new DriverYieldSignal(), | ||
| newSimpleAggregatedMemoryContext().newLocalMemoryContext(PageProcessor.class.getSimpleName()), | ||
| data.getPage())); | ||
| } | ||
|
|
||
| @SuppressWarnings("FieldMayBeFinal") | ||
| @State(Scope.Thread) | ||
| public static class BenchmarkData | ||
| { | ||
| private String name = "repeat"; | ||
|
|
||
| @Param({"10", "100", "1000"}) | ||
| private int repeatArgument = 100; | ||
|
|
||
| private Page page; | ||
| private PageProcessor pageProcessor; | ||
|
|
||
| @Setup | ||
| public void setup() | ||
| { | ||
| MetadataManager metadata = createTestMetadataManager(); | ||
| ExpressionCompiler compiler = new ExpressionCompiler(metadata, new PageFunctionCompiler(metadata, 0)); | ||
|
|
||
| Type inputType = INTEGER; | ||
| ConstantExpression inputValue = new ConstantExpression((long) 2, inputType); | ||
| ConstantExpression repeatNum = new ConstantExpression((long) repeatArgument, INTEGER); | ||
|
Contributor
There was a problem hiding this comment. Try non-const args here as well |
||
|
|
||
| ImmutableList.Builder<RowExpression> projectionsBuilder = ImmutableList.builder(); | ||
|
|
||
| FunctionHandle functionHandle = metadata.getFunctionAndTypeManager().lookupFunction(name, fromTypes(inputType, INTEGER)); | ||
| projectionsBuilder.add(new CallExpression( | ||
| name, | ||
| functionHandle, | ||
| new ArrayType(inputType), | ||
| ImmutableList.of(inputValue, repeatNum))); | ||
|
|
||
| ImmutableList<RowExpression> projections = projectionsBuilder.build(); | ||
| pageProcessor = compiler.compilePageProcessor(SESSION.getSqlFunctionProperties(), Optional.empty(), projections).get(); | ||
| page = new Page(10000); | ||
| } | ||
|
|
||
| public PageProcessor getPageProcessor() | ||
| { | ||
| return pageProcessor; | ||
| } | ||
|
|
||
| public Page getPage() | ||
| { | ||
| return page; | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why does it need to be < 10K?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is intentional to avoid generating too large array when this function was added. Since we never heard complaint about it, I think it's reasonable to keep this limit here.