[docs] document Prestissimo reduce_agg behavior#21981
Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom Feb 22, 2024
Merged
[docs] document Prestissimo reduce_agg behavior#21981tdcmeehan merged 1 commit intoprestodb:masterfrom
tdcmeehan merged 1 commit intoprestodb:masterfrom
Conversation
tdcmeehan
reviewed
Feb 21, 2024
Contributor
There was a problem hiding this comment.
Can this use a relative URL?
Contributor
Author
There was a problem hiding this comment.
Good catch! Yes it can.
Edited RST file locally to use relative URL (../functions/aggregate.html#reduce_agg), made a new local build, and tested link with relative URL.
- The link displays correctly on the page.
- Selecting the link takes me to the correct destination.
Updated PR and squashed commits.
79cceec to
b6c30ac
Compare
tdcmeehan
approved these changes
Feb 21, 2024
aditi-pandit
approved these changes
Feb 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds documentation of the behavior of reduce_agg in Prestissimo as requested in Issue 21179.
To contain this and future related content, this PR adds a new page "Prestissimo Limitations" to the Prestissimo Developer Guide documentation - parallel to the existing page "Prestissimo Features".
(The Prestissimo Developer Guide documentation was restructured in PR 21953.)
My thanks to @tdcmeehan for providing the draft explanation of the behavior of reduce_agg in Prestissimo.
Motivation and Context
Fixes Issue 21179.
Impact
Documentation.
Test Plan
Screenshots of the local build of documentation:
Contributor checklist
Release Notes