Skip to content

[native] Fix setup-centos.sh to include Velox dependencies#21976

Closed
majetideepak wants to merge 3 commits intoprestodb:masterfrom
majetideepak:fix-centos-setup
Closed

[native] Fix setup-centos.sh to include Velox dependencies#21976
majetideepak wants to merge 3 commits intoprestodb:masterfrom
majetideepak:fix-centos-setup

Conversation

@majetideepak
Copy link
Collaborator

@majetideepak majetideepak commented Feb 21, 2024

Description

Improve Centos setup script to install velox dependencies.
Remove bison from macos setup script.

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
== NO RELEASE NOTE ==

This is inline with MacOS and Ubuntu setup scripts
gperf is not required for Prestissimo.
gperf install on Ubuntu is also broken.
@majetideepak majetideepak requested a review from a team as a code owner February 21, 2024 08:35
bison is installed in the velox setup script
@majetideepak majetideepak requested a review from kgpai February 21, 2024 08:42
@majetideepak
Copy link
Collaborator Author

turns out gperf is required by proxygen.

@majetideepak majetideepak marked this pull request as draft February 21, 2024 15:40
@majetideepak majetideepak changed the title [native] Fix setup-centos.sh to include Velox dependencies and remove gperf [native] Fix setup-centos.sh to include Velox dependencies Feb 21, 2024
@majetideepak
Copy link
Collaborator Author

Adding this here #22448

@majetideepak majetideepak deleted the fix-centos-setup branch May 15, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant