Skip to content

Add support for map_key_exists#21966

Merged
NikhilCollooru merged 1 commit intoprestodb:masterfrom
jainavi17:map_key_exists
Mar 22, 2024
Merged

Add support for map_key_exists#21966
NikhilCollooru merged 1 commit intoprestodb:masterfrom
jainavi17:map_key_exists

Conversation

@jainavi17
Copy link
Contributor

@jainavi17 jainavi17 commented Feb 19, 2024

UDF to return whether a key exists in the given map

Test plan

Added unit tests.
Build successfully using the following terminal command

  • ./mvnw clean install -Dtest=TestMapKeyExists -fn -pl presto-main
== RELEASE NOTES ==

General Changes
- Add function :func:`map_key_exists`

@jainavi17 jainavi17 requested a review from a team as a code owner February 19, 2024 22:08
@jainavi17 jainavi17 requested a review from presto-oss February 19, 2024 22:08
@steveburnett
Copy link
Contributor

steveburnett commented Feb 20, 2024

Please add documentation for the new function, following the Review and Commit guidelines.

kaikalur
kaikalur previously approved these changes Feb 20, 2024
View reviewed changes
@NikhilCollooru
Copy link
Contributor

NikhilCollooru commented Feb 20, 2024 •
edited
Loading

LGTM. Please add tests as suggested by Sreeni and push the changes.

@github-actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

Codenotify: Notifying subscribers in CODENOTIFY files for diff b23ba09...6b95bd3.

Notify File(s)
@steveburnett presto-docs/src/main/sphinx/functions/map.rst

@jainavi17
Copy link
Contributor Author

jainavi17 commented Mar 4, 2024

PR updated.
cc @steveburnett , @NikhilCollooru , @kaikalur

kaikalur
kaikalur previously approved these changes Mar 4, 2024
View reviewed changes
steveburnett
steveburnett requested changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the documentation! I had minor formatting and rephrasing suggestions. Let me know what you think, please.

NikhilCollooru
NikhilCollooru previously approved these changes Mar 4, 2024
View reviewed changes
@jainavi17 jainavi17 dismissed stale reviews from NikhilCollooru and kaikalur via 1a39502 March 11, 2024 09:25
@jainavi17
Copy link
Contributor Author

jainavi17 commented Mar 11, 2024

@steveburnett Thanks for reviewing. All the comments have been addressed.

steveburnett
steveburnett previously approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull updated branch, local build of docs, looks good. Thanks!

@jainavi17
Add support for map_key_exists
6b95bd3 
UDF to return whether a key exists in the given map
@jainavi17
Copy link
Contributor Author

jainavi17 commented Mar 17, 2024

@tdcmeehan if you could take a look at the PR please. TIA.

@tdcmeehan tdcmeehan requested a review from rschlussel March 18, 2024 13:13
@jainavi17
Copy link
Contributor Author

jainavi17 commented Mar 22, 2024

@kaikalur, @NikhilCollooru can we merge this PR please.

@NikhilCollooru NikhilCollooru merged commit 754171d into prestodb:master Mar 22, 2024
@wanglinsong wanglinsong mentioned this pull request May 1, 2024
Merged
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaikalur kaikalur kaikalur left review comments

@tdcmeehan tdcmeehan tdcmeehan left review comments

@rschlussel rschlussel rschlussel approved these changes

@steveburnett steveburnett steveburnett left review comments

@NikhilCollooru NikhilCollooru NikhilCollooru left review comments

@presto-oss presto-oss Awaiting requested review from presto-oss presto-oss is a code owner automatically assigned from prestodb/committers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jainavi17 @steveburnett @NikhilCollooru @kaikalur @tdcmeehan @rschlussel