[Iceberg]Support year/month/day/hour transforms both on legacy and non-legacy TimestampType column#21959
Merged
tdcmeehan merged 2 commits intoprestodb:masterfrom Feb 28, 2024
Conversation
ec9a17b to
d2564de
Compare
ZacBlanco
requested changes
Feb 21, 2024
Contributor
ZacBlanco
left a comment
There was a problem hiding this comment.
I think the main logic looks ok. Just a few nits and one question
presto-main/src/main/java/com/facebook/presto/type/TimestampOperators.java
Outdated
Show resolved
Hide resolved
presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergPageSink.java
Outdated
Show resolved
Hide resolved
presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergPageSink.java
Outdated
Show resolved
Hide resolved
presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergPageSink.java
Outdated
Show resolved
Hide resolved
d2564de to
26ad1d2
Compare
26ad1d2 to
1176993
Compare
6 tasks
Contributor
|
Can you add to the release note an explanation of the bug fix on Timestamp to Date conversion? |
Member
Author
Sure, it has been added! Please take a look, thanks! |
Contributor
|
Changes looks good to me. In general, I see many references to the legacy system property, can we create a common function for these cases ? |
ZacBlanco
previously approved these changes
Feb 27, 2024
1176993 to
766010a
Compare
Member
Author
@gupteaj sure, good suggestion! Fixed! |
766010a to
9379d49
Compare
tdcmeehan
approved these changes
Feb 28, 2024
48 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When we create partitions on TimestampType columns(using year/month/day/hour transform) in Iceberg, we will meet various problems because of the legacy timestamp logic in presto engine do not match the logic used in Iceberg transform calculation. See issue: #7122 .
This PR fix the problems, and correct the behaviors for both legacy and non-legacy timestamp.
Test Plan
Contributor checklist
Release Notes