Documentation on Enabling SSL/TLS support for SQL Server.#21938
Documentation on Enabling SSL/TLS support for SQL Server.#21938skairali merged 1 commit intoprestodb:masterfrom sabbasani:SQL_SERVER_DOCS
Conversation
|
|
steveburnett
left a comment
There was a problem hiding this comment.
Thank you for this docs contribution! I made some suggestions to shorten a few statements, a couple of punctuation changes, and to make this draft more consistent with the existing Presto docs, but this was great. If you have any issues with my suggestions, let's discuss and figure it out together.
|
Thanks for writing a release note entry! As a suggestion using the release notes guidelines, consider the following: |
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Pulled updated branch, new local build, everything looks good.
|
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 2bd3f5e...0f48cd0.
|
steveburnett
left a comment
There was a problem hiding this comment.
Two final nits, both intended to improve readability. Let me know what you think, please!
steveburnett
left a comment
There was a problem hiding this comment.
Thanks for the very fast response today! I suggested a revision to your revision, and possibly consider adding an example of a connection-url for a truststore config.
steveburnett
left a comment
There was a problem hiding this comment.
LGTM! (docs)
Thanks for all your work!
Nit question about the new code example, everything else looks fine.
Pulled updated branch, new local build of docs, everything looks good.
skairali
left a comment
There was a problem hiding this comment.
LGTM
This is a required change and useful to all who want to enable TLS support in connections to SQL server from Presto
|
Thanks for adding this documentation. Please fix the commit message per our guidelines linked in the checklist in your PR. Suggested:
Remove all text in the body as it is superfluous. |
Thanks @tdcmeehan !! I have changed commit message as per your suggestion. |
Description
Enabling SSL support for SQL Server
Motivation and Context
Added security feature SSL/TLS where users can connect to SSL/TLS enabled Datasource.
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.