Simplify RowNumber and TopNRowNumber node with empty input#21914
Merged
feilong-liu merged 1 commit intoprestodb:masterfrom Feb 15, 2024
Merged
Simplify RowNumber and TopNRowNumber node with empty input#21914feilong-liu merged 1 commit intoprestodb:masterfrom
feilong-liu merged 1 commit intoprestodb:masterfrom
Conversation
7be2b8e to
75d7eb9
Compare
75d7eb9 to
0cbc34c
Compare
mlyublena
approved these changes
Feb 15, 2024
48 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We have an optimizer
SimplifyPlanWithEmptyInputwhich simplify query plans with empty values input. However, it does not cover RowNumber and TopNRowNumber node. In this PR, I include them so that it will also be optimized.Motivation and Context
Simplify query plan with RowNumber and TopNRowNumber with empty input.
Impact
Improve performance.
Test Plan
Unit tests
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.