Skip to content

Update MySQL JDBC driver to 8.3.0#21882

Open
Akanksha-kedia wants to merge 1 commit intoprestodb:masterfrom
Akanksha-kedia:ids
Open

Update MySQL JDBC driver to 8.3.0#21882
Akanksha-kedia wants to merge 1 commit intoprestodb:masterfrom
Akanksha-kedia:ids

Conversation

@Akanksha-kedia
Copy link
Contributor

@Akanksha-kedia Akanksha-kedia commented Feb 8, 2024

Description

This update involves upgrading the MySQL JDBC driver to version 8.3.0.

Motivation and Context

Note: This artifact was moved to:

com.mysql » mysql-connector-j

fixes #21845

MySQL Connector/J artifacts moved to reverse-DNS compliant Maven 2+ coordinates.

image

The upgrade is necessary due to the discovery of direct vulnerabilities in the earlier version of the driver, as listed below:
Direct vulnerabilities:
CVE-2022-21363
CVE-2019-2692
CVE-2018-3258

Impact

The component impacted by this update is presto-mysql. However, the impact is not significant and should not affect the overall functionality or performance.

Test Plan

Ran UT CASES
image
<img width="1700" alt="Screenshot 2023-12-14 at 4 12 07 PM" Screenshot 2023-12-14 at 4 12 07 PM
Screenshot 2023-12-14 at 4 12 27 PM

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
== RELEASE NOTES ==
Security Changes
* Upgrade MySQL JDBC driver to 8.3.0

@Akanksha-kedia Akanksha-kedia requested a review from a team as a code owner February 8, 2024 11:43
@Akanksha-kedia Akanksha-kedia changed the title Update MySQL JDBC driver to 8.1.0 Update MySQL JDBC driver to 8.3.0 Feb 8, 2024
@Akanksha-kedia Akanksha-kedia force-pushed the ids branch 3 times, most recently from 191bf42 to 06bb942 Compare February 8, 2024 13:56
@steveburnett
Copy link
Contributor

This should not be a No Release Note PR.

Based on the Release Note Guidelines, please add a properly formatted release note entry describing this change, similar to our discussion in PR 21668.

@Akanksha-kedia Akanksha-kedia force-pushed the ids branch 5 times, most recently from a449568 to 7e49333 Compare February 12, 2024 10:34
@steveburnett
Copy link
Contributor

From the Release Note Guidelines

Dependency version updates: line starts with Upgrade/Downgrade...

Please edit your release note entry accordingly. Thanks!

@Akanksha-kedia Akanksha-kedia changed the title Update MySQL JDBC driver to 8.3.0 [WIP]Update MySQL JDBC driver to 8.3.0 Feb 13, 2024
@Akanksha-kedia Akanksha-kedia changed the title [WIP]Update MySQL JDBC driver to 8.3.0 Update MySQL JDBC driver to 8.3.0 Feb 13, 2024
@Akanksha-kedia
Copy link
Contributor Author

@tdcmeehan @agrawalreetika
Screenshot 2024-02-13 at 2 42 56 PM
Screenshot 2024-02-13 at 2 43 14 PM
Screenshot 2024-02-13 at 3 16 07 PM

image
image

@steveburnett
Copy link
Contributor

From the Release Note Guidelines

Dependency version updates: line starts with Upgrade/Downgrade...

Please edit your release note entry accordingly. Thanks!

The previous comment quoted the release note guideline to show that you should change Update to Upgrade.
Dependency version updates: is not needed.

Please update the release note entry to the following:

== RELEASE NOTES ==
Security Changes
* Upgrade MySQL JDBC driver to 8.3.0

@Akanksha-kedia
Copy link
Contributor Author

done

From the Release Note Guidelines
Dependency version updates: line starts with Upgrade/Downgrade...
Please edit your release note entry accordingly. Thanks!

The previous comment quoted the release note guideline to show that you should change Update to Upgrade. Dependency version updates: is not needed.

Please update the release note entry to the following:

== RELEASE NOTES ==
Security Changes
* Upgrade MySQL JDBC driver to 8.3.0

done.

@agrawalreetika
Copy link
Member

Hi @Akanksha-kedia, Thanks for the PR.
Apart from minor nits, mostly looks good to me.
Could you please confirm when are you planning to upgrade MySQL testing server?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Declare nullOrEmpty variable as method variable on top once.
In which scenario CJException would come?

Copy link
Member

@agrawalreetika agrawalreetika Mar 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Akanksha-kedia
Copy link
Contributor Author

Akanksha-kedia commented Feb 14, 2024

Hi @Akanksha-kedia, Thanks for the PR. Apart from minor nits, mostly looks good to me. Could you please confirm when are you planning to upgrade MySQL testing server?

regarding testing server i m working on this

@Akanksha-kedia
Copy link
Contributor Author

Akanksha-kedia commented Mar 19, 2024

@tdcmeehan @agrawalreetika please review.

@Akanksha-kedia
Copy link
Contributor Author

Screenshot 2024-03-19 at 5 26 53 PM

image

i ran presto-verifier module and test coverage. and also mysql local test coverage and driver jar replaced and ran queries.

@Akanksha-kedia
Copy link
Contributor Author

@tdcmeehan @agrawalreetika please review.

@Akanksha-kedia
Copy link
Contributor Author

@tdcmeehan @agrawalreetika

@agrawalreetika
Copy link
Member

@Akanksha-kedia I see #21882 (comment) is not resolved yet. Could you please check on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade MySQL driver version to the latest version >=8.2.0 for both main and MySQL testing server

3 participants