Manifest file caching support for Iceberg Hive Catalog#21862
Closed
agrawalreetika wants to merge 2 commits intoprestodb:masterfrom
Closed
Manifest file caching support for Iceberg Hive Catalog#21862agrawalreetika wants to merge 2 commits intoprestodb:masterfrom
agrawalreetika wants to merge 2 commits intoprestodb:masterfrom
Conversation
agrawalreetika
force-pushed
the
manifest-caching-hive
branch
2 times, most recently
from
162c69a to
27dee87
Compare
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff f393c60...9a0369c. No notifications. |
imjalpreet
reviewed
Feb 6, 2024
Member
imjalpreet
left a comment
imjalpreet
left a comment
There was a problem hiding this comment.
I see there are some test failures for iceberg product tests(with kerberos and impersonation enabled). I haven't had a chance to look at all the changes yet but I suspect this might be because the iceberg library is probably not able to find the relevant hadoop configurations. Let's verify whether the config is getting passed as expected after the removal of custom FileIO in this PR.
tdcmeehan
previously approved these changes
Feb 17, 2024
Contributor
tdcmeehan
left a comment
tdcmeehan
left a comment
There was a problem hiding this comment.
Changes LGTM, please look into the test failures and fix the merge conflicts
agrawalreetika
force-pushed
the
manifest-caching-hive
branch
from
27dee87 to
c7f149b
Compare
agrawalreetika
dismissed stale reviews from tdcmeehan and steveburnett
via
c7f149b
tdcmeehan
previously approved these changes
Mar 6, 2024
Contributor
|
Please merge when you get a clean test run |
Contributor
|
Blocked on apache/iceberg#9991 |
agrawalreetika
force-pushed
the
manifest-caching-hive
branch
from
c7f149b to
9a0369c
Compare
agrawalreetika
requested review from
a team,
ZacBlanco and
elharo
as code owners
Member
Author
|
Closing this in favour of #24481 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Manifest file caching support for Iceberg Hive Catalog
Motivation and Context
Starting from Iceberg version 1.1.0, Apache Iceberg provides a mechanism to cache the contents of Iceberg manifest files in memory. This manifest caching feature helps to reduce repeated reads of small Iceberg manifest files from remote storage.
Reference: apache/iceberg#4518
Impact
No Impact. Default behaviour, Disabled. Feature can be enabled via catalog configuration changes.
Test Plan
Contributor checklist
Release Notes