Refactor ApproximateMostFrequent function to use type annotations#21751
Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom Jan 30, 2024
Merged
Conversation
tdcmeehan
approved these changes
Jan 22, 2024
This was originally authored in 8ac5ef7 but was reverted due to a regression in behavior with null values Co-authored-by: Nilay Pochhi <npochhi@rippling.com>
ZacBlanco
force-pushed
the
upstream-revert-fn-approx-freq
branch
from
d4d3ace to
6ecc3f1
Compare
feilong-liu
approved these changes
Jan 23, 2024
tdcmeehan
approved these changes
Jan 23, 2024
Contributor
Author
|
@tdcmeehan do we need another reviewer or can this be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was originally authored in 8ac5ef7 but was reverted due to a regression in behavior with null values. The fix was to remove the
@NullablePositionannotation on the input argument.Description
This fixes the original PR and adds a test case from #21712
Motivation and Context
See #21712
Impact
N/A
Test Plan
New test to cover null case
Contributor checklist
Release Notes