Skip to content

[native] Remove ShuffleReader::hasNext api #21677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiaoxmeng merged 1 commit into from
Jan 11, 2024
Merged

[native] Remove ShuffleReader::hasNext api #21677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions presto-native-execution/presto_cpp/main/operators/ShuffleInterface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,6 @@ class ShuffleReader {
public:
virtual ~ShuffleReader() = default;

/// Deprecate, do not use!
virtual bool hasNext() {
return true;
}

/// Reads the next block of data. The function returns null if it has read all
/// the data. The function throws if run into any error.
virtual velox::BufferPtr next() = 0;
Expand Down