Refactor Java Hive and Iceberg Connector for Prestissimo Iceberg Connector

[imjalpreet]

Description

Related to #21584

Motivation and Context

facebookincubator/velox#5977

Impact

N.A.

Test Plan

Contributor checklist

• Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
• PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
• Documented new properties (with its default value), SQL syntax, functions, or other functionality.
• If release notes are required, they follow the release notes guidelines.
• Adequate tests were added if applicable.
• CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

[yingsu00]

You don't need to cast to HiveColumnHandle

Set<String> relevantColumns = tableHandle.getPartitionColumns().stream()
                .map(BaseHiveColumnHandle::getName)

[yingsu00]

You don't need to cast to HiveColumnHandle

Set<String> relevantColumns = tableHandle.getPartitionColumns().stream()
                .map(BaseHiveColumnHandle::getName)

[yingsu00]

We don't usually do upcasts in the child classes. I think it's better to change the parameter partitionColumns to List<BaseColumnHandle>

[yingsu00]

Change
public Builder setPartitionColumns(List<HiveColumnHandle> partitionColumns)
to
public Builder setPartitionColumns(List<BaseHiveColumnHandle> partitionColumns)
and do downcast inside.

[yingsu00]

same

[yingsu00]

getSchemaTableName() is already in BaseHiveTableHandle. Do we still need it here?

[yingsu00]

We can make HivePartitionResult.partitionColumns List<HiveColumnHandle>, and make hivePartitionResult.getPartitionColumns() return List<BaseHiveColumnHandle>, and also make the constructor of HivePartitionResult take List<BaseHiveColumnHandle> parameter.

[yingsu00]

change the constructor parameter partitionColumns to List<BaseHiveColumnHandle> instead of doing upcasting here

[imjalpreet]

As discussed offline, we won't be able to make this change in the JSON constructor since we don't want the information to get lost while serializing.