Skip to content

[native] Enable hive.allow-drop-table in NativeQueryRunner #21641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
majetideepak merged 1 commit into from
Jan 18, 2024
Merged

[native] Enable hive.allow-drop-table in NativeQueryRunner #21641

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...xecution/src/test/java/com/facebook/presto/nativeworker/PrestoNativeQueryRunnerUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,12 @@ public static QueryRunner createNativeQueryRunner(
boolean addStorageFormatToPath)
throws Exception
{
// The property "hive.allow-drop-table" needs to be set to true because security is always "legacy" in NativeQueryRunner.
ImmutableMap<String, String> hiveProperties = ImmutableMap.<String, String>builder()
.putAll(getNativeWorkerHiveProperties(storageFormat))
.put("hive.allow-drop-table", "true")
.build();

// Make query runner with external workers for tests
return HiveQueryRunner.createQueryRunner(
ImmutableList.of(),
Expand All @@ -162,7 +168,7 @@ public static QueryRunner createNativeQueryRunner(
.build(),
ImmutableMap.of(),
"legacy",
getNativeWorkerHiveProperties(storageFormat),
hiveProperties,
workerCount,
Optional.of(Paths.get(addStorageFormatToPath ? dataDirectory + "/" + storageFormat : dataDirectory)),
Optional.of((workerIndex, discoveryUri) -> {
Expand Down