Add support for iceberg set properties#21606
Closed
pratyakshsharma wants to merge 5 commits intoprestodb:masterfrom
Closed
Add support for iceberg set properties#21606pratyakshsharma wants to merge 5 commits intoprestodb:masterfrom
pratyakshsharma wants to merge 5 commits intoprestodb:masterfrom
Conversation
Cherry-pick of trinodb/trino@72df2b9 Co-authored-by: ebyhr
Cherry-pick of trinodb/trino@cf368de Co-authored-by: ebyhr
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 0f89633...ba42733.
|
Contributor
Author
steveburnett
requested changes
Jan 2, 2024
Contributor
steveburnett
left a comment
There was a problem hiding this comment.
Thanks for the doc! A couple of small suggestions - if they don't look good to you, let me know and we'll figure it out.
Contributor
Author
|
Thank you for your review @steveburnett . I am closing the PR and these changes are now added to #21495 as a separate commit. I have addressed your review comments there itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for Iceberg ALTER TABLE SET PROPERTIES
Needs to merge after #21495 and #21250.
Docs and testing is pending.
Motivation and Context
#21251
Impact
ALTER TABLE foo SET PROPERTIES (commit_retries = 5);Test Plan
Unit testing (pending) and manual testing (done)
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.