Remove ref hash session property for Iceberg Nessie catalog#21501
Remove ref hash session property for Iceberg Nessie catalog#21501agrawalreetika wants to merge 1 commit intoprestodb:masterfrom
Conversation
|
@nastra @ajantha-bhat I was not able to locate in reviewers. Please check this. |
yingsu00
left a comment
There was a problem hiding this comment.
@agrawalreetika I checked Nessie documentation and source code, and it seems the ref hash is something like the commit hash on a git branch. If there are 2 new commits on this branch, lets say branch A, then the reference to the first commit would be (name="A", hash=[hash_commit_1]), and the reference to the latest commit is (name="A", hash=[hash_commit_2]) or just (name="A"). The "Hash on nessie.ref" in https://projectnessie.org/tools/client_config/ is not "Hash OF the nessie.ref name", but the hash of one of the commits on the reference branch. I mistakenly thought it was "Hash OF the nessie.ref name" before.
If my current understanding is correct, then we should not remove the ref hash property, but instead, we shall make it settable and validate the user's input. Nessie lib provides hash validation API, check Validation.validateHash() and validateHashOrRelativeSpec() methods. Though I think the parameter name "referenceName" in Validation.validateHash(String referenceName) is confusing. Maybe we can send a PR to Nessie to change it to "hash" instead.
cc @tdcmeehan
|
@yingsu00 Thanks for the details. Make sense, I will explore around the validation API of Nessie. In that case, we can close this PR. |
Description
Remove ref hash session property for Iceberg Nessie catalog
Motivation and Context
This came from the discussion in #21399 (comment)
We can discuss if we want to remove ref hash as session property from Presto or we want to modify existing support.
Impact
None
Test Plan
NA
Contributor checklist
Release Notes