Skip to content

Deprecate Nessie BASIC authentication type #21476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tdcmeehan merged 1 commit into from
Dec 5, 2023
Merged

Deprecate Nessie BASIC authentication type #21476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions presto-docs/src/main/sphinx/connector/iceberg.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ Property Name Description
Available values are ``BASIC`` or ``BEARER``.
Example: ``BEARER``

**Note:** Nessie BASIC authentication type is deprecated,
this will be removed in upcoming release

``iceberg.nessie.auth.basic.username`` The username to use with ``BASIC`` authentication.
Example: ``test_user``

Expand Down
5 changes: 5 additions & 0 deletions presto-iceberg/src/main/java/com/facebook/presto/iceberg/nessie/AuthenticationType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@

public enum AuthenticationType
{
/**
* Nessie BASIC authentication type is deprecated, this auth type will be removed in upcoming release.
* https://github.com/projectnessie/nessie/blob/nessie-0.59.0/api/client/src/main/java/org/projectnessie/client/NessieConfigConstants.java#L34
*/
@Deprecated
BASIC,
BEARER
}
4 changes: 4 additions & 0 deletions presto-iceberg/src/main/java/com/facebook/presto/iceberg/nessie/NessieConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,25 +75,29 @@ public Optional<AuthenticationType> getAuthenticationType()

@Config("iceberg.nessie.auth.basic.username")
@ConfigDescription("The username to use with BASIC authentication")
@Deprecated
public NessieConfig setUsername(String username)
{
this.username = username;
return this;
}

@Deprecated
public Optional<String> getUsername()
{
return Optional.ofNullable(username);
}

@Config("iceberg.nessie.auth.basic.password")
@ConfigDescription("The password to use with BASIC authentication")
@Deprecated
public NessieConfig setPassword(String password)
{
this.password = password;
return this;
}

@Deprecated
public Optional<String> getPassword()
{
return Optional.ofNullable(password);
Expand Down