Skip to content

Remove deprecated Nessie basic authentication type#21456

Closed
agrawalreetika wants to merge 1 commit intoprestodb:masterfrom
agrawalreetika:remove-nessie-basic-auth
Closed

Remove deprecated Nessie basic authentication type#21456
agrawalreetika wants to merge 1 commit intoprestodb:masterfrom
agrawalreetika:remove-nessie-basic-auth

Conversation

@agrawalreetika
Copy link
Member

Description

Remove deprecated Nessie basic authentication type

Motivation and Context

Remove deprecated Nessie basic authentication type
https://projectnessie.org/tools/client_config/#authentication-settings
https://github.com/projectnessie/nessie/blob/nessie-0.59.0/api/client/src/main/java/org/projectnessie/client/NessieConfigConstants.java#L34

Impact

None

Test Plan

NA

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@github-actions
Copy link

Codenotify: Notifying subscribers in CODENOTIFY files for diff 048672d...a46dffe.

Notify File(s)
@steveburnett presto-docs/src/main/sphinx/connector/iceberg.rst

Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Local build of docs, everything looks good.

@agrawalreetika agrawalreetika self-assigned this Nov 30, 2023
Copy link
Contributor

@yingsu00 yingsu00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agrawalreetika I think we should allow the user to have some grace period before the basic auth type is removed. Let's just mark @deprecated on these properties for now and update the doc.

@agrawalreetika
Copy link
Member Author

@agrawalreetika I think we should allow the user to have some grace period before the basic auth type is removed. Let's just mark @deprecated on these properties for now and update the doc.

Sure @yingsu00, then I will add one more commit about deprecation in this #21399 and we can keep this one for merging later. Would that work?

@yingsu00
Copy link
Contributor

yingsu00 commented Dec 4, 2023

@agrawalreetika I think we should allow the user to have some grace period before the basic auth type is removed. Let's just mark @deprecated on these properties for now and update the doc.

Sure @yingsu00, then I will add one more commit about deprecation in this #21399 and we can keep this one for merging later. Would that work?

Yes that works! After it's done can you please archive this PR?

@agrawalreetika
Copy link
Member Author

Closing in favour of #21476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants