Skip to content

Add a flag to disable tracking of partial histories#21453

Merged
arhimondr merged 1 commit intoprestodb:masterfrom
mlyublena:hbo-partial-agg-flag
Nov 30, 2023
Merged

Add a flag to disable tracking of partial histories#21453
arhimondr merged 1 commit intoprestodb:masterfrom
mlyublena:hbo-partial-agg-flag

Conversation

@mlyublena
Copy link
Contributor

@mlyublena mlyublena commented Nov 29, 2023

Description

#21160 added the capability of tracking partial aggregation statistics in HBO.
This PR adds a flag that allows us to disable tracking of that information.

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Adds a new flag track_partial_aggregation_history: when the flag is enabled, we track statistics from partial aggregation execution in HBO. 
* ...

Hive Changes
* ...
* ...

If release note is NOT required, use:

== NO RELEASE NOTE ==

@mlyublena mlyublena requested a review from a team as a code owner November 29, 2023 00:33
@vermapratyush
Copy link
Member

@mlyublena Can you please set the feature to false (as default) for presto-on-spark. That can be done here:

Also, please add the new session property to Release Notes in the PR message.

@mlyublena
Copy link
Contributor Author

@mlyublena Can you please set the feature to false (as default) for presto-on-spark. That can be done here:

Also, please add the new session property to Release Notes in the PR message.

thanks, done!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@mlyublena mlyublena force-pushed the hbo-partial-agg-flag branch 2 times, most recently from 086c605 to 941dc88 Compare November 29, 2023 22:57
Adds a flag track_partial_aggregation_history: when false, tracking of execution information for partial aggs is disabled.
@mlyublena mlyublena force-pushed the hbo-partial-agg-flag branch from 941dc88 to e983ba0 Compare November 29, 2023 23:45
@arhimondr arhimondr merged commit 381d51c into prestodb:master Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants