Skip to content

[native]Advance velox version and code update #21437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiaoxmeng merged 1 commit into from
Nov 28, 2023
Merged

[native]Advance velox version and code update #21437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions presto-native-execution/presto_cpp/main/PeriodicTaskManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,8 +565,7 @@ void PeriodicTaskManager::addSpillStatsUpdateTask() {
}

void PeriodicTaskManager::updateSpillStatsTask() {
#if 0
const auto updatedSpillStats = velox::exec::globalSpillStats();
const auto updatedSpillStats = velox::common::globalSpillStats();
VELOX_CHECK_GE(updatedSpillStats, lastSpillStats_);
const auto deltaSpillStats = updatedSpillStats - lastSpillStats_;
REPORT_IF_NOT_ZERO(kCounterSpillRuns, deltaSpillStats.spillRuns);
Expand Down Expand Up @@ -602,7 +601,6 @@ void PeriodicTaskManager::updateSpillStatsTask() {
kCounterSpillPeakMemoryBytes, spillMemoryStats.peakBytes);

lastSpillStats_ = updatedSpillStats;
#endif
}

void PeriodicTaskManager::printHttpEndpointLatencyStats() {
Expand Down
4 changes: 1 addition & 3 deletions presto-native-execution/presto_cpp/main/PeriodicTaskManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,7 @@ class PeriodicTaskManager {
int64_t lastVoluntaryContextSwitches_{0};
int64_t lastForcedContextSwitches_{0};
// Renabled this after update velox.
#if 0
velox::exec::SpillStats lastSpillStats_;
#endif
velox::common::SpillStats lastSpillStats_;
velox::memory::MemoryArbitrator::Stats lastArbitratorStats_;
};

Expand Down
2 changes: 1 addition & 1 deletion presto-native-execution/velox
Open in desktop
Submodule velox updated 290 files