Merged
Conversation
kevinwilfong
force-pushed
the
advance_velox_again
branch
3 times, most recently
from
8b9bbe7 to
0cc6eeb
Compare
To pull in facebookincubator/velox#7479 which we can use to address some errors we've been seeing when the Coordinator gets the status from the Worker.
kevinwilfong
force-pushed
the
advance_velox_again
branch
from
0cc6eeb to
0de63b6
Compare
amitkdutta
approved these changes
Nov 10, 2023
Contributor
amitkdutta
left a comment
amitkdutta
left a comment
There was a problem hiding this comment.
Looks good. Thanks @kevinwilfong
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To pull in facebookincubator/velox#7479 which we can use to address some errors we've been seeing when the Coordinator gets the status from the Worker.