Skip to content

Disallow dropping partition column in Iceberg table explicitly #21294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hantangwangd merged 1 commit into from
Nov 4, 2023
Merged

Disallow dropping partition column in Iceberg table explicitly #21294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergAbstractMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,17 @@ public void dropColumn(ConnectorSession session, ConnectorTableHandle tableHandl
IcebergTableHandle icebergTableHandle = (IcebergTableHandle) tableHandle;
IcebergColumnHandle handle = (IcebergColumnHandle) column;
Table icebergTable = getIcebergTable(session, icebergTableHandle.getSchemaTableName());

// Currently drop partition column used in any partition specs of a table would introduce some problems in Iceberg.
// So we explicitly disallow dropping partition columns until Iceberg fix this problem.
// See https://github.com/apache/iceberg/issues/4563
boolean shouldNotDropPartitionColumn = icebergTable.specs().values().stream()
.flatMap(partitionSpec -> partitionSpec.fields().stream())
.anyMatch(field -> field.sourceId() == handle.getId());
if (shouldNotDropPartitionColumn) {
throw new PrestoException(NOT_SUPPORTED, "This connector does not support dropping columns which exist in any of the table's partition specs");
}

icebergTable.updateSchema().deleteColumn(handle.getName()).commit();
}

Expand Down
17 changes: 17 additions & 0 deletions presto-iceberg/src/test/java/com/facebook/presto/iceberg/IcebergDistributedTestBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,23 @@ public void testAddPartitionColumn()
assertQuerySucceeds("DROP TABLE add_partition_column");
}

@Test
public void testDropPartitionColumn()
{
assertQuerySucceeds("create table test_drop_partition_column(a int, b varchar) with (partitioning = ARRAY['a'])");
assertQuerySucceeds("insert into test_drop_partition_column values(1, '1001'), (2, '1002'), (3, '1003')");
String errorMessage = "This connector does not support dropping columns which exist in any of the table's partition specs";
assertQueryFails("alter table test_drop_partition_column drop column a", errorMessage);
assertQuerySucceeds("DROP TABLE test_drop_partition_column");

assertQuerySucceeds("create table test_drop_partition_column(a int)");
assertQuerySucceeds("insert into test_drop_partition_column values 1, 2, 3");
assertQuerySucceeds("alter table test_drop_partition_column add column b varchar with (partitioning = 'identity')");
assertQuerySucceeds("insert into test_drop_partition_column values(4, '1004'), (5, '1005')");
assertQueryFails("alter table test_drop_partition_column drop column b", errorMessage);
assertQuerySucceeds("DROP TABLE test_drop_partition_column");
}

@Test
public void testTruncate()
{
Expand Down