Enable timestamp type for SHOW STATS command#21286
Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom Nov 3, 2023
Merged
Conversation
tdcmeehan
approved these changes
Nov 1, 2023
s-akhtar-baig
approved these changes
Nov 1, 2023
Contributor
s-akhtar-baig
left a comment
There was a problem hiding this comment.
Never mind my last comment, I checked the SqlTimestamp::toString and it uses time zone. These changes look good to me, thanks!
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Presto issue #20929
Motivation and Context
-Display min/max statistics for timestamp column in iceberg tables.
-SHOW STATS will use time zone from user session's property.
-Before fix, SHOW STATS would return error
Unexpected type: timestampNote : Hive table will need additional support for min/max on timestamp column.
Impact
Fixed error "Unexpected type: timestamp"
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.