Convert values node followed by false filter to empty values node#21275
Merged
NikhilCollooru merged 1 commit intoprestodb:masterfrom Nov 1, 2023
Merged
Convert values node followed by false filter to empty values node#21275NikhilCollooru merged 1 commit intoprestodb:masterfrom
NikhilCollooru merged 1 commit intoprestodb:masterfrom
Conversation
mlyublena
approved these changes
Oct 30, 2023
4b47cf7 to
3a17e12
Compare
NikhilCollooru
approved these changes
Nov 1, 2023
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Run
RemoveTrivialFiltersaftersimplifyRowExpressionOptimizer, so that queries likeselect * from (values 1, 2) t(k) where 1=0will be simplified as empty values node.Motivation and Context
Values node followed by false filter is not optimized:
With the change here:
The following
SimplifyPlanWithEmptyInputcan further simplify the empty value nodes.Impact
Better performance
Test Plan
Easy change
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.