Skip to content

Update MSSQL Server JDBC driver to 12.6.0.jre8#21195

Closed
Akanksha-kedia wants to merge 1 commit intoprestodb:masterfrom
Akanksha-kedia:sqlbase
Closed

Update MSSQL Server JDBC driver to 12.6.0.jre8#21195
Akanksha-kedia wants to merge 1 commit intoprestodb:masterfrom
Akanksha-kedia:sqlbase

Conversation

@Akanksha-kedia
Copy link
Contributor

@Akanksha-kedia Akanksha-kedia commented Oct 20, 2023

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* ...
* ...

Hive Changes
* ...
* ...

If release note is NOT required, use:

== NO RELEASE NOTE ==

@Akanksha-kedia Akanksha-kedia requested a review from a team as a code owner October 20, 2023 06:27
@Akanksha-kedia
Copy link
Contributor Author

@tdcmeehan @skairali please review and merge.

@Akanksha-kedia
Copy link
Contributor Author

Screenshot 2023-10-20 at 12 24 18 PM we are still Screenshot 2023-10-20 at 12 24 29 PM using still old version when new versions are compatible and non-vunerable.

@tdcmeehan
Copy link
Contributor

@Akanksha-kedia have you tested the SQL server driver with the updated dependency?

@tdcmeehan tdcmeehan self-assigned this Oct 20, 2023
@tdcmeehan tdcmeehan removed their assignment Nov 3, 2023
@Akanksha-kedia Akanksha-kedia changed the title Update MSSQL Server JDBC driver to 12.4.1.jre8 Update MSSQL Server JDBC driver to 12.6.0.jre8 Feb 8, 2024
@steveburnett
Copy link
Contributor

Based on the Release Note Guidelines, please add a properly formatted release note entry describing this change, similar to our discussion in PR 21668.

@agrawalreetika
Copy link
Member

Hi @Akanksha-kedia
Thank you for the PR. I don't see UT added for sql-server connector currently, I will add an issue regarding the same. So I have the same question as Tim, did you test sql-server connector after updating the dependency and could you please share the results?

@agrawalreetika
Copy link
Member

I have added issue for adding UTs here - #21890
Also found out that product tests for sql-server were disabled as part of microsoft/mssql-docker#76
and as per the comment here, the Issue no longer exists if we make use of microsoft/mssql-server-linux:2017-CU13 docker image instead.
It would be good if you want to enable Product tests for it and test out your changes as well.

@Akanksha-kedia Akanksha-kedia force-pushed the sqlbase branch 2 times, most recently from 5ee7874 to f829750 Compare February 11, 2024 10:27
@elharo
Copy link
Contributor

elharo commented Sep 17, 2024

stale, closing due to conflicts

@elharo elharo closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants